Closed carterbox closed 6 months ago
Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
src/tike/ptycho/position.py
:Line 285:81: E501 line too long (95 > 80 characters) Line 676:81: E501 line too long (104 > 80 characters)
Purpose
Mitigate position correction slowly moving the object out of the field of view.
Approach
Use only the center half of the object patches to compute the position update directions. This avoids noise around the edges where information is less dense.
Subtract the mean position update direction using trim_mean before each update. This in theory should keep the object centered by preventing net movement. In practice, there is still a small amount of movement each epoch.
Pre-Merge Checklists
Submitter
Reviewer