API: Add leading dimension to object for multi-slice - Githubissues

AdvancedPhotonSource / tike

Repository for ptychography software

http://tike.readthedocs.io

Other

29 stars 15 forks source link

API: Add leading dimension to object for multi-slice #314

Closed carterbox closed 5 months ago

carterbox commented 5 months ago

Purpose

Adds a leading dimension to the reconstructed object in preparation for multi-slice objects.

Approach

Refactor the Pytcho Operator and related Operators to accept a 3-dimensional psi array, where the first dimension is a placeholder singleton dimension for future multi-slice operations.
Remove unused adjoint methods which will make implementing multi-slice more difficult
Add a ZeroPropagation Operator as a placeholder for the between-slice Operator.
Add a SingleSlice Operator as a placeholder for a MultiSlice Operator.

Pre-Merge Checklists

Submitter

[ ] Write a helpfully descriptive pull request title.
[ ] Organize changes into logically grouped commits with descriptive commit messages.
[ ] Document all new functions.
[ ] Click 'details' on the readthedocs check to view the updated docs.
[ ] Write tests for new functions or explain why they are not needed.
[ ] Address any complaints from pep8speaks.

Reviewer

[ ] Actually read all of the code.
[ ] Run the new code yourself; the included tests should make this easy.
[ ] Write a summary of the changes as you understand them.
[ ] Thank the submitter.

pep8speaks commented 5 months ago

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/tike/operators/cupy/ptycho.py:

Line 51:81: E501 line too long (81 > 80 characters)

In the file src/tike/ptycho/solvers/options.py:

Line 162:81: E501 line too long (85 > 80 characters)

Comment last updated at 2024-05-28 17:44:57 UTC