NEW: Add affine transformation to INFO logging output - Githubissues

AdvancedPhotonSource / tike

Repository for ptychography software

http://tike.readthedocs.io

Other

29 stars 15 forks source link

NEW: Add affine transformation to INFO logging output #317

Closed carterbox closed 4 months ago

carterbox commented 4 months ago

Purpose

Notify the user if a global scaling is detected, so they can adjust their detector distance / beam energy accordingly.

Approach

Pre-Merge Checklists

Submitter

[ ] Write a helpfully descriptive pull request title.
[ ] Organize changes into logically grouped commits with descriptive commit messages.
[ ] Document all new functions.
[ ] Click 'details' on the readthedocs check to view the updated docs.
[ ] Write tests for new functions or explain why they are not needed.
[ ] Address any complaints from pep8speaks.

Reviewer

[ ] Actually read all of the code.
[ ] Run the new code yourself; the included tests should make this easy.
[ ] Write a summary of the changes as you understand them.
[ ] Thank the submitter.

pep8speaks commented 4 months ago

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/tike/ptycho/ptycho.py:

Line 238:81: E501 line too long (86 > 80 characters) Line 239:81: E501 line too long (81 > 80 characters) Line 946:81: E501 line too long (94 > 80 characters) Line 947:81: E501 line too long (89 > 80 characters)

Comment last updated at 2024-06-10 20:40:36 UTC