REF: Get number of slices dynamically at runtime - Githubissues

AdvancedPhotonSource / tike

Repository for ptychography software

http://tike.readthedocs.io

Other

29 stars 15 forks source link

REF: Get number of slices dynamically at runtime #321

Closed carterbox closed 4 months ago

carterbox commented 4 months ago

Purpose

Remove initialization parameter for nslices from operators
Add test dataset for multislice reconstruction
Compute object preconditioner for every slice instead of just first slice

Approach

Pre-Merge Checklists

Submitter

[x] Write a helpfully descriptive pull request title.
[ ] Organize changes into logically grouped commits with descriptive commit messages.
[x] Document all new functions.
[ ] Click 'details' on the readthedocs check to view the updated docs.
[ ] Write tests for new functions or explain why they are not needed.
[ ] Address any complaints from pep8speaks.

Reviewer

[ ] Actually read all of the code.
[ ] Run the new code yourself; the included tests should make this easy.
[ ] Write a summary of the changes as you understand them.
[ ] Thank the submitter.

pep8speaks commented 4 months ago

Hello @carterbox! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/ptycho/templates.py:

Line 49:81: E501 line too long (81 > 80 characters) Line 55:81: E501 line too long (87 > 80 characters) Line 68:81: E501 line too long (85 > 80 characters)