REF: Change how costs are reduced - Githubissues

AdvancedPhotonSource / tike

Repository for ptychography software

http://tike.readthedocs.io

Other

29 stars 15 forks source link

REF: Change how costs are reduced #327

Closed carterbox closed 3 months ago

carterbox commented 3 months ago

Purpose

Try to avoid host synchronization during cost function computation.

Approach

Store objective function values in an GPU array until the end of the epoch.

Pre-Merge Checklists

Submitter

[ ] Write a helpfully descriptive pull request title.
[ ] Organize changes into logically grouped commits with descriptive commit messages.
[ ] Document all new functions.
[ ] Click 'details' on the readthedocs check to view the updated docs.
[ ] Write tests for new functions or explain why they are not needed.
[ ] Address any complaints from pep8speaks.

Reviewer

[ ] Actually read all of the code.
[ ] Run the new code yourself; the included tests should make this easy.
[ ] Write a summary of the changes as you understand them.
[ ] Thank the submitter.

pep8speaks commented 3 months ago

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/tike/ptycho/solvers/lstsq.py:

Line 291:81: E501 line too long (90 > 80 characters) Line 321:81: E501 line too long (90 > 80 characters)

In the file src/tike/ptycho/solvers/rpie.py:

Line 105:81: E501 line too long (85 > 80 characters) Line 185:81: E501 line too long (82 > 80 characters)

Comment last updated at 2024-07-29 15:19:00 UTC