Implement Dwivedi's method for position correction - Githubissues

AdvancedPhotonSource / tike

Repository for ptychography software

http://tike.readthedocs.io

Other

29 stars 15 forks source link

Implement Dwivedi's method for position correction #45

Closed carterbox closed 4 years ago

carterbox commented 4 years ago

Purpose

Implement an easy position correction method just to have at least one. Also, boosted CPU performance by using Numba to compile some functions.

Approach

Dwivedi, Priya, A.P. Konijnenberg, S.F. Pereira, and H.P. Urbach. 2018.
“Lateral Position Correction in Ptychography Using the Gradient of
Intensity Patterns.” Ultramicroscopy 192 (September): 29–36.
https://doi.org/10.1016/j.ultramic.2018.04.004.

Pre-Merge Checklists

Submitter

[x] Write a helpfully descriptive pull request title.
[x] Organize changes into logically grouped commits with descriptive commit messages.
[x] Document all new functions.
[ ] Write tests for new functions or explain why they are not needed.
[ ] Build the documentation successfully
[x] Use yapf to format python code.

Reviewer

[ ] Actually read all of the code.
[ ] Run the new code yourself.
[ ] Write a summary of the changes as you understand them.
[ ] Thank the submitter.

pep8speaks commented 4 years ago

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/tike/operators/convolution.py:

Line 172:13: E741 ambiguous variable name 'l'

Comment last updated at 2020-04-21 22:03:27 UTC