AdvancedPhotonSource / tike

Repository for ptychography software
http://tike.readthedocs.io
Other
29 stars 15 forks source link

REF: Change initial step sizes for line search #71

Closed carterbox closed 4 years ago

carterbox commented 4 years ago

Purpose

Decrease the time spend line searching with minimal effort. Related to #61, #60 .

Approach

Adjusted the initial step sizes for the ptychography solver according to my observations from two real datasets. While the probe step size seems to remain on the order of 1, the object step size consistently shrinks to the order of 1e-5. I guessed that this was related the scan area.

My observation is that applying the smaller initial step for the object update decreases times per epoch by an order of magnitude.

Pre-Merge Checklists

Submitter

Reviewer

pep8speaks commented 4 years ago

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-08-14 19:45:27 UTC