Closed carterbox closed 4 years ago
The num_gpu
parameter is still in the argument list of recon()
, but internal functions can access the attributes of the Pool
to get the number of GPUs. If you are implementing some kind of primary and secondary groupings of GPUs, then this can be included as a property of the pool. Is that acceptable?
Yes, that's acceptable. It would be great to add GPU grouping as a feature of the pool.
Purpose
Unify the multi- and single- GPU code paths to improve readability and maintainability.
Approach
Removes additional if-else statements for single- and multi- GPU implementations by using function substitution and the Pool class.
Pre-Merge Checklists
Submitter
yapf
to format python code.Reviewer