Open carterbox opened 4 years ago
Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
src/tike/admm/pal.py
:Line 137:21: E131 continuation line unaligned for hanging indent Line 141:21: E131 continuation line unaligned for hanging indent
src/tike/admm/subproblem/__init__.py
:Line 35:1: E402 module level import not at top of file Line 36:1: E402 module level import not at top of file Line 37:1: E402 module level import not at top of file
src/tike/admm/subproblem/align.py
:src/tike/align/align.py
:src/tike/align/solvers/cgrad.py
:Line 27:13: E122 continuation line missing indentation or outdented
src/tike/align/solvers/cross_correlation.py
:Line 52:81: E501 line too long (81 > 80 characters)
src/tike/operators/cupy/gradient.py
:Line 19:31: E201 whitespace after '[' Line 19:45: E201 whitespace after '['
src/tike/ptycho/ptycho.py
:Line 352:81: E501 line too long (95 > 80 characters)
tests/operators/test_gradient.py
:Line 32:24: E201 whitespace after '{' Line 32:31: E202 whitespace before '}'
Purpose
Provide a function for solving the lamino-alignment problem with ADMM.
Approach
Solve the laminography + alignment problem using the Laminography operators, Lanczos Interpolation operator, and Flow solver which wraps OpenCV's Farneback's method.
Also includes some changes to the ThreadPool and scatter/gather CUDA kernels which should be merged separately.
Pre-Merge Checklists
Submitter
yapf
to format python code.Reviewer