search

AdvancedPhotonSource / xdesign

Tools for designing x-ray phantoms and experiments.
https://xdesign.readthedocs.io
Other
24 stars 16 forks source link

Replacement of noise addition way to measurement #56

Closed dgursoy closed 5 years ago

dgursoy commented 6 years ago

This proposes to use percentage values (of the measurement for calculating the standard deviation) instead of standard deviation.

carterbox commented 6 years ago

Also, Travis fails because this API change breaks test_aquisition.

dgursoy commented 6 years ago

Tests need to be updated accordingly.

carterbox commented 5 years ago

Because the computation of intersections is so expensive, it is better to add noise as a post-processing step instead of adding it (irreversibly) to the data during simulation. From v0.4 onwards, acquisition.Probe will not have a noise model.