AdvancedPlugins / Jobs

AdvancedJobs is the ultimate Spigot Jobs Plugin that allows you to create your own custom jobs without any programming knowledge.
https://advancedplugins.net/item/AdvancedJobs.187/
1 stars 0 forks source link

Unify progress/rewards system #36

Closed Tolmwn closed 1 day ago

Tolmwn commented 1 week ago

Describe the bug

I found i bug at the progress file, the %required_progress% at level 2 its wronth. It's need to be 0/20 but its show 0/5. I send and screenshots for it.

How to reproduce

image image

Screenshots / Videos

No response

Server Log

No response

KPGTB commented 1 week ago

Hey! You made a small mistake during configuration. You shouldn't add progress into current level (currentLevel) item, because you already unlocked this level. Job menu shows required progress to unlock next level, so when you are on 2nd level, you need to break 20 logs to unlock 3rd level. In progress menu you see required progress to specific level, so to unlock 3rd level, you need to break 20 logs.

Tolmwn commented 1 week ago
  1. But the progress is already in currentlevel from you. I just change the text from it.

That what i only need is to show ppl how much they need at each level to get the levelup ! I think its a bug or its from

"# Required Progress required-progress: "10 * %level%" "

KPGTB commented 1 week ago

Default configuration of progress items (in progress.yml):

lockedLevel:
  item:
    material: red_stained_glass_pane
    name: "&a%job% &fLvl. &e%level%"
    lore:
      - ''
      - '&fRewards:'
      - '  &8>>&a Global Points: &f%points%'
      - '  &8>>&a &f%rewards value%'
      - ''
      - '&fTo Unlock:'
      - '  &8>>&a &f%total_progress%/%required_progress% progress required'

unlockedLevel:
  item:
    material: green_stained_glass_pane
    name: "&a%job% &fLvl. &e%level%"
    lore:
      - ''
      - '&fRewards:'
      - '  &8>>&a Global Points: &f%points%'
      - '  &8>>&a &f%rewards value%'
      - ''
      - '&fTo Unlock:'
      - '  &8>>&a Already unlocked'

currentLevel:
  item:
    material: yellow_stained_glass_pane
    name: "&a%job% &fLvl. &e%level%"
    lore:
      - ''
      - '&fRewards:'
      - '  &8>>&a Global Points: &f%points%'
      - '  &8>>&a &f%rewards value%'
      - ''
      - '&fTo Unlock:'
      - '  &8>>&a Already unlocked'
Tolmwn commented 1 week ago

Sorry but i think you make a mistake, you did it wroth. How its possible to be the currentlevel unlocked before i unlock it ? People want to see how much more they need to do so they can level up but if they can see only the lockedlevel then is something wroth. Idk if you can understand me :/

KPGTB commented 1 week ago

But current level is your current level. You unlocked it and to unlock next level, you need to make a progress which is visible in job description.

KPGTB commented 1 week ago

As you can see on this image

Your current level: 2 Progress to unlock 3rd level: 7/20

image

Tolmwn commented 1 week ago

Its possible please to make a api for the current level too? I want to add it at the progress file too so ppl that dont understand its can be show. But i understand now what you mean.

KPGTB commented 1 week ago

So, if you understand how it works, what do you want to show in current level? You already unlocked that level - you don't need to make any progress to be on that level

Tolmwn commented 1 week ago

image image image image

That what i want it's only that the "currentLevel" is be showing the player the same required progress as at the FREE and PREMIUM MENUS and then the "lockedLevel" is be showing his required progress for how much they gonna need to levelup and get the rewards.

So how can i make that at the "currentLevel" to have the same required progress as the text at the FREE and PREMIUM MENUS?? That what i only need.

It's just showing the Level 1 and Level 2 with the same requirement. I can't put at the Level 1 to be already be showing like the player has levelup it because is he not. He need to do first eat 20 consumables before he can get the rewards that its be showing at each level.

Tolmwn commented 1 week ago

Hey again, it's possible to get a asnwer if that is possible or not? I really want it !! Thank you :)

KPGTB commented 6 days ago

Hey! I see where is the problem which causes misunderstanding. Current level shows your current level and progress shows progress to the next level, but rewards are from the previous level. I.e. when you are at 2nd level, the progress in free/premium job menu is to 3rd level, but when you get 3rd level you get rewards from 2nd level.

I'll think about it and soon I'll release an update to progress/rewards system which will unify it.

Thanks for your report and sorry for the late response, kpg_tb

KPGTB commented 2 days ago

Hey! I created PR which changes progress menu placeholders to make it simpler to understand. Now it will work like you wanted - currentLevel will show current progress, other items will show progress required to get reward when player is on that level. Updated system will be available soon (probably in the next update)

Tolmwn commented 2 days ago

Good thank you :)