search

AdvancedPlugins / Seasons

Experience dynamic seasons in Minecraft with Advanced Seasons, the most immersive seasons plugin available.
Apache License 2.0
2 stars 1 forks source link

Performance loss with setting biome for season (see spark report) #43

Closed Technofied closed 6 months ago

Technofied commented 7 months ago

Describe the bug

Set biome is resource intensive and could be further optimised. See the spark report attached in "PLUGIN" view

How to reproduce

Use the plugin (I'm not entirely sure how to reproduce)

Screenshots / Videos

https://spark.lucko.me/RNPJH4AO8f (spark report)

Server Log

No response

GC-spigot commented 7 months ago

It's all done async and does not lag the actual server thread. Are you having TPS or any other issues?

This is all a built-in minecraft/spigot function and it's unlikely we can further optimize it, but that's why it's done separately away from actual server - shouldn't cause any issues, Your TPS seems to be doing well.

GC-spigot commented 7 months ago

I updated a few things for 1.20.4 plugin version, let me know if this helps you.

Technofied commented 7 months ago

I updated a few things for 1.20.4 plugin version, let me know if this helps you.

https://spark.lucko.me/akqiLep2On

Here we are with more players, sadly it isn't doing so well

GC-spigot commented 7 months ago

While we're looking into what optimization we can do, we can suggest lowering the view distance - this should reduce some lag for you. We have had positive feedback on performance from other servers, and are looking into what is causing this case. Thanks!

GC-spigot commented 6 months ago

Should be improved!