Water doesn't freeze in winter

[Pilvinen]

Describe the bug

Spigot with Minecraft 1.20.6 AdvancedSeasons 1.2.7 update. ProtocolLib dev [#689] May 6, 2024, 5:02 PM

Water doesn't freeze during winter. I tried disabling all other plugins except AdvancedSeasons and ProtocolLib.

No errors on console. Nothing in logs.

How to reproduce

1) Install Spigot 1.20.6 and dev version of protocolLib that runs on 1.20.6 2) Install AdvancedSeasons. 3) Set season to winter. 4) Nothing happens to water.

Screenshots / Videos

https://snipboard.io/8rXLsh.jpg

Server Log

No response

[Ynverxe]

Try using the default config. If the problem dissapears, send all your config files to see where's the error.

[Ynverxe]

Another thing, go to the river/ocean and then use F3 to determine the biome name, then go to biomeConfiguration/.yml and check that the winter.winter-frezee section is in TRUE. If not, set it to "true", restart your server and run /season setseason and /season setseason winter and check.

[Pilvinen]

Biome settings are on defaults.

I also set the calendar.yml to default settings and restarted in between. It seemed to make no difference, the issue still persists.

But I will try to isolate it further by setting up a Spigot 1.20.6 test server which runs only ProtocolLib and AdvancedSeasons on default settings. I will report back how it goes later today.

[Pilvinen]

I'm sorry to say, but AdvancedBiomes 1.2.7 is definitely broken on Spigot 1.20.6 using default configuration. I'm seeing the seasonal visual effects. And I'm seeing the biome as forests_winter_0. The temperature is also below freezing. But the water does not freeze.

1) java -jar BuildTools.jar --rev=1.20.6 2) Run, accept eula. 3) Copy over ProtocolLib.jar and AdvancedSeasons.jar 4) Run /seasons addworld testworld 5) Run /seasons setseason winter

I will paste my test server configs, but there's nothing super special in them (AdvancedSeasons is 100% default config):

server.properties: https://pastebin.com/1xcE3C7c

bukkit.yml: https://pastebin.com/201eyXJ0

spigot.yml: https://pastebin.com/qShaXAtF

Screenshot:

[Pilvinen]

Not sure if the chunk info is relevant or what it means exactly. But it's showing spring.

[Pilvinen]

Seems like water doesn't freeze in winter unless it's raining (?) so this is likely the same issue as ticket #91