AdvancedPlugins / Seasons

Experience dynamic seasons in Minecraft with Advanced Seasons, the most immersive seasons plugin available.
Apache License 2.0
1 stars 1 forks source link

Time doesn't progress in winter #93

Open Pilvinen opened 1 month ago

Pilvinen commented 1 month ago

Describe the bug

Spigot with Minecraft 1.20.6 Latest AdvancedSeasons. ProtocolLib dev [#689] May 6, 2024, 5:02 PM

Days don't advance in winter. It's always the first day of winter.

No errors on console. Nothing in logs.

How to reproduce

Screenshots / Videos

No response

Server Log

No response

Pilvinen commented 1 month ago

On closer look it's possible this is caused on my server by setting /gamerule doDaylightCycle false and then progressing the time manually every X tick.

However, on setting /gamerule doDaylightCycle true it seems that calendar.yml settings don't really do anything. The day in the game is vanilla Minecraft length even when I set settings such as:

time:
# In Vanilla: entire day in normal minecraft is 20 minutes
spring:
# Length of day time, in real world minutes
dayLength: 40
nightLength: 40
summer:
dayLength: 60
nightLength: 20
fall:
dayLength: 40
nightLength: 40
winter:
dayLength: 28
nightLength: 52

# Seasons Progression
progression:
# Should season progression be paused? Set to true to pause
paused: false

calendar:
# How many days should one season last
seasonDays: 2
# How many days should it take to transition between seasons?
transitionDays: 1

Overall I would say that AdvancedSeasons on Minecraft 1.20.6 is pretty much almost entirely broken.

And I would hope that this situation gets some immediate attention.

Pilvinen commented 1 month ago

No. I double checked. Apparently I was wrong. During winter the calendar progression completely stops and setting /gamerule doDaylightCycle false doesn't seem to affect that.

So the calendar.yml settings not taking effect seems like a separate issues and I'll open a new ticket on that.

Ynverxe commented 1 month ago

https://github.com/AdvancedPlugins/Seasons/issues/95

Your calendar.yml is wrong. You cannot make a MC day cycle during more than 20 minutes. I'm not saying that this is the cause of the bug, if it persists, come back here and send all your config files, and your logs/latest.log if it's possible.

Pilvinen commented 1 month ago

Setting calendar.yml to default settings did not fix the issue on my main server. But time progression does seem to work on my test server with only ProtocolLib and AdvancedSeasons with default config.

So, I'm not sure what breaks it at my main server. I guess I will have to start going over all the AdvancedSeasons settings and see if I can get it to break on my test server.

Pilvinen commented 1 month ago

Still having this problem in 1.3.0. When it's winter it's always the first day of winter. I haven't been able to figure out which setting might cause this.