search

AdvancedPlugins / Seasons

Experience dynamic seasons in Minecraft with Advanced Seasons, the most immersive seasons plugin available.
Apache License 2.0
1 stars 1 forks source link

Crop growth multiplier doesn't affect growth of pitcherplant #94

Open Pilvinen opened 1 month ago

Pilvinen commented 1 month ago

Describe the bug

Spigot with Minecraft 1.20.6 Latest AdvancedSeasons. ProtocolLib dev [#689] May 6, 2024, 5:02 PM

Crop growth multiplier doesn't affect growth of pitcherplant.

How to reproduce

Install Spigot 1.20.6 and dev version of protocolLib that runs on 1.20.6 Install AdvancedSeasons. Set growth to low value. Plant a pitcher plant. Watch it grow like crazy.

Screenshots / Videos

No response

Server Log

No response

Ynverxe commented 1 month ago

Normally this plant should have 2 blocks, by any chance the plant doesn't grow from 1 block up and looks like a clipped texture? I tried it and that's what's happening to me, I want to make sure it's the same behavior as yours.

Pilvinen commented 1 month ago

Normally this plant should have 2 blocks, by any chance the plant doesn't grow from 1 block up and looks like a clipped texture? I tried it and that's what's happening to me, I want to make sure it's the same behavior as yours.

For me it looks visually normal, it just grows very very fast.

Ynverxe commented 1 month ago

For me it looks visually normal, it just grows very very fast. Can I see your crops.yml?

Pilvinen commented 1 month ago

For me it looks visually normal, it just grows very very fast. Can I see your crops.yml?


# Is custom crops handling enabled?
enabled: true

Crop growth multiplier

growth: SPRING: 0.8 SUMMER: 1.0 FALL: 0.5 WINTER: 0.25

winterGrowth:

Should crops only grow in winter if they are lit up and in positive temperature, as well as under a block?

If set to false, crops will bypass the checks and use value set from growth setting for winter.

If set to true, if crop doesn't pass the checks it will not grow.

basedOnConditions: true

Temperature needed for crops to grow in winter

tempThreshold: 10


And, from Spigot.yml:

growth: cactus-modifier: 25 cane-modifier: 25 melon-modifier: 25 mushroom-modifier: 25 pumpkin-modifier: 25 sapling-modifier: 25 beetroot-modifier: 25 carrot-modifier: 25 potato-modifier: 25 wheat-modifier: 25 netherwart-modifier: 25 vine-modifier: 25 cocoa-modifier: 25 bamboo-modifier: 25 sweetberry-modifier: 25 kelp-modifier: 25 twistingvines-modifier: 25 weepingvines-modifier: 25 cavevines-modifier: 25

Ynverxe commented 3 weeks ago

Hi, after do a little research, this bug is caused because Spigot doesn't takes care the grow of certain plants. So when a PitcherCrop is growing the server never calls the API. This bug is fixed on PaperMC.

https://github.com/PaperMC/Paper/pull/9242 https://github.com/PaperMC/Paper/blob/master/patches/server/0842-Call-BlockGrowEvent-for-missing-blocks.patch