search

Advanon / pdf-signatures

Nodejs package to sign pdfs with external electronic signatures (PKCS7)
GNU Affero General Public License v3.0
16 stars 6 forks source link

Add Windows support, remove vulnerabilities #10

Closed erkstruwe closed 3 years ago

erkstruwe commented 3 years ago

Hi!

I added a small change to make the package support multi-line responses on Windows machines. Additionally, I ran npm update and npm audit fix to remove ~40k vulnerabilities. This will most likely close all open pull requests created by dependabot as well.

Since I don't have a Linux machine set up, I couldn't run the build script. Could you please run that, make another commit with changed files and republish on npm? Much appreciated!

Also, I changed version to 0.1.0 to obey semantic versioning rules.

pandomic commented 3 years ago

@erkstruwe thank you for your contribution. Will will try to review the PR shortly

erkstruwe commented 3 years ago

Yes, done. Thanks for your review.

erkstruwe commented 3 years ago

Oh, alright. I'm a total JS guy, don't know what I'm doing in terms of Java... Tests are working, though.