Adventech / sabbath-school-ios

📘 Sabbath School for iOS
https://itunes.apple.com/us/app/sabbath-school/id895272167?mt=8
MIT License
63 stars 29 forks source link

Bible verse links are not working (iPad app) #131

Open webknows opened 1 year ago

webknows commented 1 year ago

Whenever I touch a link to a Bible verse mention inside a Sabbath School text, nothing happens.

Steps to reproduce:

  1. open up the Sabbath School app
  2. select any Standard Adult lesson from the list on the first row
  3. touch the 'Read' button underneath the lesson's date (or select a week's lesson from the list)
  4. scroll down the text until a Bible verse mention is found (the text is underscored, indicating it is a link)
  5. touch the Bible verse mention

Expected result:

Current result:

Version information:

VitalikL commented 1 year ago

@EmersonCarpes Can you please take a look at this? I can not reproduce on my real device.

EmersonCarpes commented 1 year ago

@VitalikLI tried to reproduce here on an iPad Air real device and in the simulator of iPad Pro both are ok.

@webknows is this happening for all bible verse or is a specific case? Could you send a video please?

webknows commented 1 year ago

GitHub doesn’t like the size of that file, so https://share.icloud.com/photos/003pru8WbIllJf0v3_cZz2iMg

On Dec 24, 2022 at 11:07 AM -0600, Rivanor Soares @.***>, wrote:

Yes, it’s happening for all verses, on any lessons. Video’s attached.

  • Reeve

On Dec 24, 2022 at 10:26 AM -0600, Emerson Carpes @.***>, wrote:

@VitalikLI tried to reproduce here on an iPad Air real device and in the simulator of iPad Pro both are ok. @webknows is this happening for all bible verse or is a specific case? Could you send a video please? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

EmersonCarpes commented 1 year ago

@webknows looks like you are using a mouse, right? If you tap directly on iPad screen the issue still happen? I tried to connect my Magic Mouse, but even this way works for me.

webknows commented 1 year ago

When I made the video I was using the Magic Keyboard's trackpad as input and connected to the iPad. If I remove the keyboard/trackpad, and use only my fingers to tap, I have the same result. On Dec 24, 2022, 12:31 PM -0600, Emerson Carpes @.***>, wrote:

@webknows looks like you are using a mouse, right? If you tap directly on iPad screen the issue still happen? I tried to connect my Magic Mouse, but even this way works for me. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

altati44 commented 9 months ago

The Bible link doesn't work

VitalikL commented 9 months ago

@altati44 Can you please provide screen recording? This issue has been quite hard to reproduce

altati44 commented 9 months ago

I attached a short video, you can watch when I touch the verses link nothing happens. Thank you.

On Fri, Jan 5, 2024 at 7:49 PM VitalikL @.***> wrote:

@altati44 https://github.com/altati44 Can you please provide screen recording? This issue has been quite hard to reproduce

— Reply to this email directly, view it on GitHub https://github.com/Adventech/sabbath-school-ios/issues/131#issuecomment-1879491352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWRX766WQHC74K5FTMN3FDYNCUTPAVCNFSM6AAAAAATF4UU7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGQ4TCMZVGI . You are receiving this because you were mentioned.Message ID: @.***>