Adventure-Terraria-Server-Project / Protector-Plugin

Protector plugin for Terraria Server API and TShock.
GNU General Public License v3.0
10 stars 19 forks source link

Bankchest Issue #17

Closed Stealownz closed 10 years ago

Stealownz commented 10 years ago

Test 1:{ place "chest", make bchest 1 put in first slot "dirt block" break "chest" returned "inactive stone block" break and check again: still "inactive stone block" }

Items Change Bug: It seems items convert to these items as such: Previous item (ID) -> New Item in Bankchest (ID) Dirt block (2) -> Inactive Stone Block (512) Stone Block (3) -> Bone Block Wall (768) Iron Broadsword (4) -> Teal and Black dye (1024) Mushroom (5) -> Sailor Pants (1280) Iron Shortsword (6) -> hallowed key (1536) Iron Hammer (7) -> Pumpkin Chair (1792)

Item ID past 7, corrupting chest bug. Any Items past ID 7, regardless of item amount or which slot, placed inside a bankchest will create an empty bankchest with only one chest slot. The slot is empty, clicking on the slot causes the entire bankchest slots to reappear, but still empty. Pressing Loot all corrupts Player's inventory, causing some inv slots to be lost. Relog fixes the lost inv slots. Relog resets bankchest if loot all was clicked.

Item Quantities Bugs: Tested with Dirt Block & Stone Block: Dirt Block still turns to Inactive Stone Block, Stone Block turns to Bone Block Wall. If dirt block has this much quantity then:

1 - 255 Dirt Block --> Same amount Inactive Stone Block 256 -> Disappear - No Icon, hover over says "Large Inactive Stone Block" no number. 265 -> 9 Prefix Large added. 266 -> 10 ^ 300 -> 44 ^ 350 -> 94 ^ 400 -> 144 ^ 450 -> 154 ^ 500 -> 244 ^ 550 -> 38 Prefix Massive added 600 -> 88 ^ 650 -> 138 ^ 700 -> 188 ^ 750 -> 328 ^ 800 -> 32 Inactive Stone Block 850 -> 82 ^ 900 -> 132 ^ 999 -> 231 ^

Items after Third Row Bug Test 2{ Place Chest, make bchest 1 Place a dirt block in any slot at First or Second Row. Place a dirt block in any slot at Third or Fourth Row. Try to break bankchest, Chest doesn't break, but gets deprotected. Any dirt block at the first or second row disappears in that unprotected chest. Any dirt block at the third or fourth row stays as it was. Place another chest, make bchest 1 All slots with dirt blocks in any row have been converted to Inactive Stone Block. }

Note: If item placed inside for test 2 has item number greater than 7, the Chest Corrupting bug partially occurs instead, where part of the right side chest slots disappear, while the other side gets the Items after Third Row Bug.

CoderCow commented 10 years ago

A recent pull request in the Plugin Common Library might fix this issue.