search

Adventure-Terraria-Server-Project / Protector-Plugin

Protector plugin for Terraria Server API and TShock.
GNU General Public License v3.0
10 stars 19 forks source link

Quick Stack Nearby Broken #47

Open CoderCow opened 8 years ago

CoderCow commented 8 years ago

Causes items to get lost or bank chest not to update properly or not to work at all. Quick Stack Nearby is therefore disabled completely at the moment.

antagonist99 commented 7 years ago

With this new hook (Packet 85) is there any possibility of changing the current code to work?

Quick Stack Nearby is really a very useful function, even if it does not initially work with safe chests.

Thank very much for keeping this project active.

CoderCow commented 7 years ago

Yes, it is possible and Protector is actually using this packet already. The distribution of the items to be stacked is just buggy. Though it will require a decent amount of time to fix and test this.

tedstark commented 6 years ago

Hello, I'm a new user of TShock and your plugin. Is there any update to getting Quick Stack Nearby to work?

CoderCow commented 6 years ago

Nope, because neither me nor other people have shown much interest in getting this fixed. It actually looks like most players are fine with managing their items manually.

tedstark commented 6 years ago

Hmm, I guess I'm just lazy. :D Okay, thanks for the reply anyway!

adiran commented 5 years ago

Hey, i'm managing a small TShock server for my friends and me and we use QuickStack very often because its way faster than manually sorting your inventory. Because we want to build a big, fancy world i am currently looking for a plugin to extend the 1000 Chests limit. But it seems that nether your plugin nor the InfinityChest Plugin implement the QuickStack Hook properly. I'm currently looking at your implementation and trying to figure out whats wrong with it. Unfortunatly i have no experience in creating TShock Plugins. Maybe you can tell me a little bit more about the problem with this method? There must be an implementation of QuickStack in the TShock code but i only found the method OnItemForceIntoChest which performs some checks but doesn't do anything else. Can you tell me where i can found a working implementation of QuickStack to compare with your implementation? It would be cool if you can help me with this infos so i can fix this implementation. Your Plugin seems to be very cool and i would appreciate to use it. Greets Adrian