search

Adversarial-Deep-Learning / code-soup

This is a collection of algorithms and approaches used in the book adversarial deep learning
MIT License
18 stars 18 forks source link

Tutorial for GAN #1 #16

Closed someshsingh22 closed 2 years ago

someshsingh22 commented 3 years ago

Create Tutorials outside package

Devanshu24 commented 3 years ago

Regarding the first point, I think the imports are working right? Any specific that you found to be broken?

someshsingh22 commented 3 years ago

The imports are working because the imports in mnist_gan.py are direct, the init.py has some imports that are not working and the build cases pass, I will put a detailed error log in a while

someshsingh22 commented 3 years ago

scripts written in code_soup or subfolders would not run because the reference to modules is absolute, however, the tutorials were supposed to be following code soup structure which will need relative imports.

However according to PEP8: Relative vs Absolute Imports Relative Imports are discouraged, so we will follow the layout for tutorials outside the main code. Changing the tasks and issue.

abhi-glitchhg commented 3 years ago

Can I take up this task?

someshsingh22 commented 3 years ago

Yes @abhi-glitchhg you can take this up, please keep updating your progress/plan