Adversarial-Deep-Learning / code-soup

This is a collection of algorithms and approaches used in the book adversarial deep learning

MIT License

18 stars 18 forks source link

Add AllConvNet #44

Closed Shreyas-Bhat closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 (41c2256) into main (7f7d0e9) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines           86       139   +53     
=========================================
+ Hits            86       139   +53

Impacted Files	Coverage Δ
code_soup/common/vision/models/allconvnet.py	`100.00% <100.00%> (ø)`

someshsingh22 commented 3 years ago

@Shreyas-Bhat please lint as given in Contributing.md Also add tests at tests/common/vision/models/test_allconv.py

someshsingh22 commented 3 years ago

@Shreyas-Bhat your PR fails because its not matching black / isort standards. Please lint your code properly with black, isort and flake to merge this.

someshsingh22 commented 3 years ago

@Shreyas-Bhat Is this PR the same as #46 ? In that case I will close this PR

Shreyas-Bhat commented 3 years ago

@Shreyas-Bhat Is this PR the same as #46 ? In that case I will close this PR

@someshsingh22 Yes, it is the same, you may close it

someshsingh22 commented 3 years ago

Closing because its a duplicate of #46