search

Adversarial-Deep-Learning / code-soup

This is a collection of algorithms and approaches used in the book adversarial deep learning
MIT License
18 stars 18 forks source link

Add logger #64

Open arihantbansal opened 2 years ago

arihantbansal commented 2 years ago

This PR resolves Issue #23.

codecov[bot] commented 2 years ago

Codecov Report

Merging #64 (c6ba6f0) into main (191a0a9) will decrease coverage by 4.08%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##              main      #64      +/-   ##
===========================================
- Coverage   100.00%   95.91%   -4.09%     
===========================================
  Files           17       19       +2     
  Lines          704      734      +30     
===========================================
  Hits           704      704              
- Misses           0       30      +30
Impacted Files Coverage Δ
code_soup/utils/__init__.py 0.00% <0.00%> (ø)
code_soup/utils/logger.py 0.00% <0.00%> (ø)
someshsingh22 commented 2 years ago

@arihantbansal Can you try implementing your logger in the GAN Tutorial notebook so we can merge it ?

someshsingh22 commented 2 years ago

@arihantbansal can you write the tests to complete the PR, Tensorboard and Tutorial test can be integrated in a different PR

arihantbansal commented 2 years ago

@arihantbansal can you write the tests to complete the PR, Tensorboard and Tutorial test can be integrated in a different PR

I'll try fix the callback logging and implement it in the tutorial by EOD. What are the requirements for the tests?