search

Adversarial-Deep-Learning / code-soup

This is a collection of algorithms and approaches used in the book adversarial deep learning
MIT License
18 stars 18 forks source link

Add seeding and checkpoints #67

Closed soham-chitnis10 closed 3 years ago

soham-chitnis10 commented 3 years ago

This PR resolves issue #60

codecov[bot] commented 3 years ago

Codecov Report

Merging #67 (65130af) into main (f8b07b8) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        15    +2     
  Lines          578       597   +19     
=========================================
+ Hits           578       597   +19
Impacted Files Coverage Δ
code_soup/common/utils/__init__.py 100.00% <100.00%> (ø)
code_soup/common/utils/checkpoints.py 100.00% <100.00%> (ø)
code_soup/common/utils/seeding.py 100.00% <100.00%> (ø)
gchhablani commented 3 years ago

@soham-chitnis10 I am also adding a seed function in #42. Can you please check if I can remove it from my PR?

Please add deterministic, etc. from my PR.

CC @someshsingh22

soham-chitnis10 commented 3 years ago

@gchhablani I can add deterministic and benchmark

someshsingh22 commented 3 years ago

@soham-chitnis10 several changes here.

  1. Seeding for CUDA isnt proper here, it will throw errors if cuda isnt found make separate functions for that