Adversarial-Deep-Learning / code-soup

This is a collection of algorithms and approaches used in the book adversarial deep learning

MIT License

18 stars 18 forks source link

Seperate Linting workflow; Setup pre-commit #9

Closed Devanshu24 closed 3 years ago

Devanshu24 commented 3 years ago

Mainly a PR to clean up the CI workflows and add a few more useful ones Feedback/Suggestions are welcome!

Fixes #10

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@b49ef20). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 9bf9ebf differs from pull request most recent head 5e3bc4b. Consider uploading reports for the commit 5e3bc4b to get more accurate results

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   80.00%           
=======================================
  Files           ?        2           
  Lines           ?        5           
  Branches        ?        0           
=======================================
  Hits            ?        4           
  Misses          ?        1           
  Partials        ?        0

Devanshu24 commented 3 years ago

@someshsingh22 Have a look, changed quite a few things but hopefully it should all work now

someshsingh22 commented 3 years ago

We have changed the repository name in the latest PR #8, can you rename code-soup to code_soup ? Its causing issues in the Imports @Devanshu24

someshsingh22 commented 3 years ago

@Devanshu24 Latest PR has caused some merge conflicts, you can overwrite them

Devanshu24 commented 3 years ago

There will be linting failures from #9 I think we should resolve them after merging this, to avoid cluttering a single PR

someshsingh22 commented 3 years ago

Great so I am merging this and we can set up a final cleanup