Advik-B / CMPDL

Curseforge ModPack Downloader
GNU General Public License v3.0
11 stars 1 forks source link

Issue 4 add cli support (Sourcery refactored) #6

Closed sourcery-ai[bot] closed 2 years ago

sourcery-ai[bot] commented 2 years ago

Pull Request #5 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the issue-4-Add_CLI_support branch, then run:

git fetch origin sourcery/issue-4-Add_CLI_support
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

pep8speaks commented 2 years ago

Hello @sourcery-ai[bot]! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 107:22: E231 missing whitespace after ':' Line 107:22: E701 multiple statements on one line (colon) Line 107:23: E225 missing whitespace around operator

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.32%.

Quality metrics Before After Change
Complexity 0.80 ⭐ 0.80 ⭐ 0.00
Method Length 53.55 ⭐ 53.45 ⭐ -0.10 👍
Working memory 8.49 🙂 8.58 🙂 0.09 👎
Quality 73.19% 🙂 72.87% 🙂 -0.32% 👎
Other metrics Before After Change
Lines 152 151 -1
Changed files Quality Before Quality After Quality Change
src/main.py 73.19% 🙂 72.87% 🙂 -0.32% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/main.py UI.__init__ 1 ⭐ 242 ⛔ 15 😞 46.82% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!