AdvisorySG / ghost-advisory-theme

Custom-built Ghost theme for Advisory SG.
MIT License
6 stars 12 forks source link

Implement GScan validation #189

Closed wei2912 closed 3 years ago

wei2912 commented 3 years ago

Currently, the Ghost themes are not scanned with GScan which helps to validate Ghost themes and flag out potential issues. A CI workflow should be set up to perform this scanning.

bnjmnt4n commented 3 years ago

Seems like this is already run in the CI workflow: https://github.com/AdvisorySG/ghost-advisory-theme/blob/8d43461292458c632c4ed663e5c2872d374f5326/package.json#L15, although it currently only fails on fatal errors.

wei2912 commented 3 years ago

Hmm, that might be why I didn't notice it. Guess I'll close this...