search

AdvisorySG / ghost-advisory-theme

Custom-built Ghost theme for Advisory SG.
MIT License
6 stars 12 forks source link

Dylans bugfixing #285

Closed DaDevChia closed 3 years ago

DaDevChia commented 3 years ago

Fixed contributors object to correct array type from string type

DaDevChia commented 3 years ago

Fixed context unaware {{#each}} with {{#foreach}}

DaDevChia commented 3 years ago

https://github.com/AdvisorySG/ghost-advisory-theme/blob/65314182c5ad6926d7dba7f00b19ac8900bcb613/.husky/pre-commit#L1-L4

https://github.com/AdvisorySG/ghost-advisory-theme/blob/61adcc9eed50900838eee4f49bbca49a59e12ac8/.husky/pre-commit#L1-L4

Fixed Yarn dependency issue by switching to npx

wei2912 commented 3 years ago

@DaDevChia Please revert the change you made to .husky/pre-commit. npm prepare will be executed after npm install, so there is no need to specify the packages.

wei2912 commented 3 years ago

Merged in https://github.com/AdvisorySG/ghost-advisory-theme/commit/ab0281bbfce6f8873ae1d1d1b01afa37d2a77b05, closing. Thanks for the fixes!