{{#each}} context unaware bug

AdvisorySG / ghost-advisory-theme

Custom-built Ghost theme for Advisory SG.

MIT License

6 stars 12 forks source link

{{#each}} context unaware bug #286

Closed DaDevChia closed 3 years ago

DaDevChia commented 3 years ago

Replacing {{#each}} with {{#foreach}} fixes the above bug.

wei2912 commented 3 years ago

As mentioned in https://github.com/AdvisorySG/ghost-advisory-theme/pull/285#discussion_r688860705, this warning can be safely ignored. Our current structure is such that we have two "variants" of Handlebars operating on different .hbs files, in an attempt to replace direct DOM manipulation code.

Closing this issue for now; feel free to open another issue if you have any suggestions for replacements to HTML generation.

wei2912 commented 3 years ago

Actually, I might explore Alpine.js. It's probably sufficient for our purposes and can get rid of having to do webpack + Handlebars integration, which is honestly kinda dirty