search

Adwise / magento2-nl_NL-language

Magento 2 (CE) Dutch Language Pack - Translated, optimized and maintained by Adwise
http://www.adwise.nl/
9 stars 17 forks source link

Make dependency on magento/framework more open #5

Closed hostep closed 8 years ago

hostep commented 8 years ago

Hi guys

Big thank you for the translation pack, awesome work!

This pull request opens up the composer dependency on magento/framework version. Otherwise you can't use this module in combination with Magento 2.1 (rc versions at the moment).

The caret type is the preferred way to set up version constraints, because right now your constraint only allowed changes on the third number. This fix will also allow the second number to change (which happens in Magento 2.1: 100.1.xxx). Backwards incompatible changes happen when the first number changes, so as long as the magento/framework versions follow semver, everything should work out fine.

Adwise commented 8 years ago

@hostep ,

Thank you for your work on our package. We will review it shortly!