search

AdyRock / com.ady.button_plus

GNU General Public License v3.0
2 stars 3 forks source link

Add zone grouping for devices #63

Closed vincent8balls closed 8 months ago

vincent8balls commented 8 months ago

Add device zone grouping into device selection settings. So you can better see in which zone a device is.

vincent8balls commented 8 months ago

@AdyRock There is still a bug in display configurations, I am running into after using it. Wil fix this later today.

Edit: Fixed it

AdyRock commented 8 months ago

It looks like the zone is in zone.name and not zoneName.

vincent8balls commented 8 months ago

@AdyRock Thats strange. Is there a difference between devices? Because its working on my device. What device do you have?

AdyRock commented 8 months ago

I am testing on a HP2023. Maybe Athom have made a change to the API between the Homey types, What are you using?

vincent8balls commented 8 months ago

I am testing on a HP2023. Maybe Athom have made a change to the API between the Homey types, What are you using?

I am using Homey from 2017 (Old one, haha). There its using zone.name.

I can check if its working with your change on my device as well. Can do it tomorrow. Otherwise, we can do something like this: device.zone.name ?? device.zoneName

AdyRock commented 8 months ago

I will try it on my old Homey this evening to see what I get then. The main issue is the Display gets confused if more than one Homey tries to configure it, hence I stick to my new Homey (which I still use for testing only). I have tried to find a way to cope with multiple Homey controllers, but at the moment the Configuration is one way.

AdyRock commented 8 months ago

I found a bit of time to check on my old Homey and it seems that provides both zoneName and zone.name. So if we go with zone.name that will work on both.