AdyRock / com.ady.button_plus

GNU General Public License v3.0
2 stars 3 forks source link

Buttons on connector # 3 (lowest) don't change when setting new button configuration #79

Closed Torch1969 closed 7 months ago

Torch1969 commented 8 months ago

Homey

Describe the bug Bar on connector 3 (lowest connector) cannot be set to a configuration (in device and when using the flow card)

To Reproduce In device select connector selection screen, select button bar connector 4 and select a button config #. The device isn't changed In flow select action card "change to button . Fill with 3 and with any configured button configuration number.

Expected behaviour Buttons on device change to the defined buttons in the chosen button configuration

ferdw commented 8 months ago

hmmm, I cant confirm this issue on a 2023, there it is working.

AAdam-Microfocus commented 8 months ago

Have the same issue, cannot configure bar on connector 3 with HP2023.

grafik
AdyRock commented 8 months ago

There does seem to be a firmware bug that prevents the top label from updating if it was previously blank. Restarting the panel then shows the correct label.

AdyRock commented 8 months ago

I have just realised that card is using connector 0 to 3 instead of 1 to 4. Not sure if I should change that now for consistency because that will break existing flows.

AdyRock commented 8 months ago

I have risked it and changed a few of the flows so all are now consistently using connectors 1 to 4.

Torch1969 commented 8 months ago

I discovered this problem only shows up when using a “too big” configuration (@AdyRock you know what I mean). When using a smaller configuration with less items to show/use it works fine.

AdyRock commented 7 months ago

Can you confirm if this is still an issue with the latest version? I have added a pull request to increase the decode buffer size plus add ability to send each button configuration separately, so if it's still an issue then hopefully that will get through and solve the problem.

Torch1969 commented 7 months ago

Button bar configuration on connector 4 can now be changed from device configuration. I assume it also works now from flow cards, no time to check that. I suppose problem solved

Torch1969 commented 7 months ago

@AdyRock is also tested the flowchart from flow. This also works ok know.

Problem solved. Closed issue