Adyen / adyen-3ds2-android

Apache License 2.0
26 stars 8 forks source link

Support custom url path for OOB flow #54

Closed mikkoville closed 1 year ago

mikkoville commented 1 year ago

We are having a problem since we want to update our app to use the new OOB flow released in https://github.com/Adyen/adyen-3ds2-android/releases/tag/2.2.12.

In the docs you tell us to implement support for Android app links the following way: https://docs.adyen.com/online-payments/classic-integrations/api-integration-ecommerce/3d-secure/native-3ds2/android-sdk-integration#handling-android-app-links

It says in the docs:

"Copy the following code to your app Manifest file. Replace the value of android:host from {yourapp.com} with your web domain name. Do not change any other configuration."

I have question about the "Do not change any other configuration" part.

The problem:

My main question is: Can we change the url path to somethin else than "/adyen3ds2" ?

We are already hosting another generic path in our domain that fits the purpose and would like to use that instead.

I would imagine it is ok since we then just specify our own path in the AndroidManifest like this:

<data
                android:host=""{yourapp.com}""
                android:pathPrefix="/our_custom_path"
                android:scheme="https" />

And then when we create the ChallengeParameters for the sdk we add:

challengeParameters.setThreeDSRequestorAppURL("https://{yourapp.com}/our_custom_path")

Does the above work? or is there some reason in the docs it says: "Do not change any other configuration"

NOTE I did contact Adyen support first and they did tell me I cannot change the url path from/adyen3ds2. I felt little bit they did not understand my problem so I decided to create this issue also to get more clarity.

This is blocking us into optiong into the OOB flow if we cannot use a custom path url.

Thanks

tkuntubayev commented 1 year ago

Hi @mikkoville Thank you for raising the question!

Can we change the url path to somethin else than "/adyen3ds2" ? Yes, it's possible to use your custom path in the same way as shown on your code examples. The only requirement is that the full link with your custom path should generate unique App Link that is only connected to 3DS2 ChallengeActivity. /adyen3ds2 path is shown on the docs to generate unique App link for ChallengeActivity.

Hope this helps!

mikkoville commented 1 year ago

@tkuntubayev thanks! I guess it would be good idea to fix the docs then since it is quite confusing since it says: "Do not change any other configuration"

tkuntubayev commented 1 year ago

Docs page was updated recently. Thank you for suggestion!