search

Adyen / adyen-3ds2-ios

Other
18 stars 12 forks source link

Wrong ADY3DS2SDKVersion value #25

Closed rokridi closed 3 years ago

rokridi commented 3 years ago

Hello. It is mentioned in the documentation that the current SDK version is stored in ADY3DS2SDKVersion. I suppose its value should be 2.2.3 if i am using the last SDK version, however i get 18 as a value. There is also a [little mistake](https://github.com/Adyen/adyen-3ds2-ios#:~:text=let%20threeDS2SDKVersion%20%3D%20ADY3DS2SDKVersion()) inside the ReadMe: ADY3DS2SDKVersion is not a function => () should be omitted. Thanks.

mohammedDehairy commented 3 years ago

Hi @rokridi ,

Thanks for reaching out!. :-)

You're right, the value should be 2.2.3 if you're using the latest version, and I did test it and it is indeed 2.2.3, and it is indeed a function, and you should call it with ().

How can I reproduce the 18 value? can you share some code snippet? because I can't reproduce what you describe.

Mohamed

rokridi commented 3 years ago

Hi @mohammedDehairy Thanks for the reply. Here, take a look at the screen shots.

Capture d’écran 2021-10-07 à 09 26 37 Capture d’écran 2021-10-07 à 09 24 30
mohammedDehairy commented 3 years ago

@rokridi ,

Ah, no, you should use let version = ADY3DS2SDKVersion() NOT let version = Adyen3DS2VersionNumber, they're not the same :-).

sorry, it can be confusing, but its clear in the README file that its let version = ADY3DS2SDKVersion().

Mohamed

rokridi commented 3 years ago

@mohammedDehairy My bad 😅 Thanks for clearing it up.