search

Adyen / adyen-cse-web

[DEPRECATED] Client-side encryption on JavaScript
MIT License
15 stars 39 forks source link

Package name #39

Closed Joe-Withey closed 5 years ago

Joe-Withey commented 7 years ago

You guys have renamed your package.json name property in 5d253b7. Are you in the process of updating the github repo name also? It should match. Are you planning on publishing the library as a package on npm?

ArnoudAdyen commented 7 years ago

Hi,

The repository name was changed some time ago to be more consistent with other packages Adyen offers. The package.json and bower.json have been updated to reflect that change.

There are no plans currently to publishing the library as a package on npm, as we prefer merchants to use the hosted version of the library instead.

Joe-Withey commented 7 years ago

Sorry referenced the wrong commit d1a266cc26319f43c3d22bb0bc47b6cc263738d7. You've also updated the repository URL so you can confirm this is also going to change?

chris-verclytte commented 7 years ago

+1, it seems like a regression as d1a266c overwrite modifications made by 4423e3e earlier with wrong information (like git repo url for example).

gilbarbara commented 7 years ago

The repo is called adyen-cse-web but it creates a folder adyen-cse-js inside the nodemodules. What a mess! ¯_(ツ)/¯

Also both github and npm are hosted, I really can't understand the difference...

ArnoudAdyen commented 7 years ago

With Hosted CSE we mean the adyen hosted CSE in which your public key is embedded. This allows transparent keyrolling to happen, which is not possible when you use a github or npm hosted version and keep the public key in your server configuration. See the HostedCSE.md

smolnikov commented 7 years ago

Created #59 to make installation examples in readme work.