Adyen / adyen-cse-web

[DEPRECATED] Client-side encryption on JavaScript
MIT License
15 stars 39 forks source link

Please rename this dependency to match its repo name? #62

Closed martynchamberlin closed 5 years ago

martynchamberlin commented 7 years ago

We include this repo as a dependency in our package.json like so:

"adyen-cse-js": "git+https://github.com/Adyen/adyen-cse-web.git#v0.1.20.1",

We are on NPM 5. Very routinely, in Jenkins CI we get this error:

npm WARN checkPermissions Missing write access to 
/some/path/to/node_modules/adyen-cse-js

We have hundreds of dependencies in our package.json and we never get this error on any others. When we re-run CI, the problem usually goes away.

I'm not sure if adyen-cse-web actually has permission problems with contents. I suspect it's rather something to do with the fact that this repo's dependency name does not match is repo name. Would love to get these two consistent. Whether you choose to rename the repo or the dependency name doesn't matter to me; which ever one is easiest and most friction-free.

Thanks!