Adyen / adyen-magento2-express-checkout

Adyen Magento 2 Express Checkout Module
MIT License
11 stars 6 forks source link

[ECP-9533] Submit Quote Observer - quite inconvenient logic inside #129

Closed roby0404 closed 3 weeks ago

roby0404 commented 1 month ago

Can you please refactor the mentioned observer: https://github.com/Adyen/adyen-magento2-express-checkout/blob/main/Observer/SubmitQuoteObserver.php as it looks like logic inside it was intended only for adyen paypal express payment method, but most of the logic is applied to all orders.

Big issue here is that it forcefully sets all orders to Pending status and New state - interrupting the usual flow and causing orders that would usually end up in Processing status/state to be stuck in Pending - for example 'No payment method required' orders, or orders paid with payment methods that directly charge the customer and create an invoice automatically.

candemiralp commented 3 weeks ago

Hello @roby0404,

Thank you for reporting this issue. We have validated the bug and started working on it. The pull request will be created soon.

Best Regards, Can