search

Adyen / adyen-magento2-express-checkout

Adyen Magento 2 Express Checkout Module
MIT License
11 stars 6 forks source link

[ECP-9533] Fix the PayPal quote submit observer updates irrelevant orders #135

Closed candemiralp closed 3 weeks ago

candemiralp commented 3 weeks ago

Summary

The observer class used to update all orders' status regardless of checking the payment method. Ideally, this observer had to run for orders with adyen_paypal_express payment method. In addition, since the observer has the same name with the SubmitQuoteObserver in Adyen Payment plugin for Magento 2 repository, it used to override the former one.

This PR introduces a fix to these two issues via refactoring the the code to update the condition and rename the observer class and observer name in the events definition file.

Tested scenarios

Fixes #129 Fixes #131

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud