search

Adyen / adyen-magento2-express-checkout

Adyen Magento 2 Express Checkout Module
MIT License
8 stars 2 forks source link

Add Apple Pay button color option #51

Closed dimitriBouteille closed 7 months ago

dimitriBouteille commented 8 months ago

Summary

This PR adds the ability to choose the style of the Apple Pay button. In addition, the GooglePay and Apple Pay methods are separated into 2 different groups to improve configuration management.

Capture d’écran du 2023-11-02 15-56-18 Capture d’écran du 2023-11-02 15-56-28

Issue: #50

dimitriBouteille commented 8 months ago

config.buttonColor ?? 'black' must be used in view/frontend/web/js/helpers/getApplePayStyles.js

dimitriBouteille commented 8 months ago

Thank you @hossam-adyen , I corrected the feedback and made the correction for this comment https://github.com/Adyen/adyen-magento2-express-checkout/pull/51#issuecomment-1798233930.

For me it's good :)

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication