Adyen / adyen-magento2-express-checkout

Adyen Magento 2 Express Checkout Module
MIT License
11 stars 6 forks source link

[ECP-9158] Checkout not working with required agreements #66

Open dimitriBouteille opened 11 months ago

dimitriBouteille commented 11 months ago

Describe the bug

When I try place order with Apple Pay, I have the following error :

The order wasn't placed. First, agree to the terms and conditions, then try placing your order again.

To Reproduce

Steps to reproduce the behavior:

Expected behavior

Agreements validation must be disabled with express checkout.

Error trace

{
    "message": "Die Bestellung wurde noch nicht platziert. Bitte stimmen Sie erst unseren Nutzungsbedingungen zu und versuchen Sie dann die Bestellung erneut abzusenden.",
    "trace": "#0 /vendor/magento/module-checkout-agreements/Model/Checkout/Plugin/GuestValidation.php(80): Magento\\CheckoutAgreements\\Model\\Checkout\\Plugin\\GuestValidation->validateAgreements()\n#1 /vendor/magento/framework/Interception/Interceptor.php(121): Magento\\CheckoutAgreements\\Model\\Checkout\\Plugin\\GuestValidation->beforeSavePaymentInformationAndPlaceOrder()\n#2 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\\Checkout\\Model\\GuestPaymentInformationManagement\\Interceptor->Magento\\Framework\\Interception\\{closure}()\n#3 /generated/code/Magento/Checkout/Model/GuestPaymentInformationManagement/Interceptor.php(23): Magento\\Checkout\\Model\\GuestPaymentInformationManagement\\Interceptor->___callPlugins()\n#4 [internal function]: Magento\\Checkout\\Model\\GuestPaymentInformationManagement\\Interceptor->savePaymentInformationAndPlaceOrder()\n#5 /vendor/magento/module-webapi/Controller/Rest/SynchronousRequestProcessor.php(95): call_user_func_array()\n#6 /vendor/magento/module-webapi/Controller/Rest.php(195): Magento\\Webapi\\Controller\\Rest\\SynchronousRequestProcessor->process()\n#7 /vendor/magento/framework/Interception/Interceptor.php(58): Magento\\Webapi\\Controller\\Rest->dispatch()\n#8 /vendor/magento/framework/Interception/Interceptor.php(138): Magento\\Webapi\\Controller\\Rest\\Interceptor->___callParent()\n#9 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\\Webapi\\Controller\\Rest\\Interceptor->Magento\\Framework\\Interception\\{closure}()\n#10 /generated/code/Magento/Webapi/Controller/Rest/Interceptor.php(23): Magento\\Webapi\\Controller\\Rest\\Interceptor->___callPlugins()\n#11 /vendor/magento/framework/App/Http.php(116): Magento\\Webapi\\Controller\\Rest\\Interceptor->dispatch()\n#12 /vendor/magento/framework/Interception/Interceptor.php(58): Magento\\Framework\\App\\Http->launch()\n#13 /vendor/magento/framework/Interception/Interceptor.php(138): Magento\\Framework\\App\\Http\\Interceptor->___callParent()\n#14 /vendor/magento/framework/Interception/Interceptor.php(153): Magento\\Framework\\App\\Http\\Interceptor->Magento\\Framework\\Interception\\{closure}()\n#15 /generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\\Framework\\App\\Http\\Interceptor->___callPlugins()\n#16 /vendor/magento/framework/App/Bootstrap.php(264): Magento\\Framework\\App\\Http\\Interceptor->launch()\n#17 /pub/index.php(30): Magento\\Framework\\App\\Bootstrap->run()\n#18 {main}"
}
candemiralp commented 7 months ago

Hello @dimitriBouteille,

Thank you for raising this issue. We have created an internal ticket to solve this one.

Best regards, Can

candemiralp commented 4 months ago

Hello @dimitriBouteille,

We have created a PR to fix the issue on Apple Pay. We didn't observe any issue on Google Pay and it works as expected with agreements.

Best Regards, Can