search

Adyen / adyen-magento2-express-checkout

Adyen Magento 2 Express Checkout Module
MIT License
8 stars 2 forks source link

Checkout agreements #67

Closed dimitriBouteille closed 5 months ago

dimitriBouteille commented 6 months ago

This MR corrects the following error: The order wasn't placed. First, agree to the terms and conditions, then try placing your order again.

Until now the agreeements were retrieved via the variable window.checkout.agreementIds, this variable does not exist (in Adyen and Magento), the agreements are passed directly in the data-mage-init.

💎 I passed the properties of the AbstractButton class to protected in order not to dupplicate the code in the children class:)

Fixed issue: #66

:warning: This fix must be implemented in Adyen v8 (1.x) and v9 (2.x) please !

sonarcloud[bot] commented 6 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

candemiralp commented 6 months ago

Hello @dimitriBouteille,

Thank you for your contribution. We will review this PR and merge it afterwards.

Best Regards, Can