search

Adyen / adyen-magento2-hyva

MIT License
7 stars 4 forks source link

CreditCardPayment.spec.js failing with default configuration for showing holder name #13

Closed pmarjan-onestic closed 8 months ago

pmarjan-onestic commented 9 months ago

Steps to reproduce:

By default "Show holder name field for car payment method" is set to "No", and we leave it like that..

MAGENTO_BASE_URL="https://adyen-local.onestic.dev/" npx playwright test --workers=1 --headed --project=user --config=projects/magento/magento.config.cjs projects/magento/tests/CreditCardPayment.spec.js

Expected result: we get 4 passing tests

Actual results: all tests fail

Extra info: All tests "hang" before clicking the "Place Order". Finally, an observable error from the reports may look like

Screenshot from 2024-02-27 14-15-00

RokPopov commented 9 months ago

Hi @pmarjan-onestic, the tests failing on this one are expected behavior. The reason for it is this ->

By default "Show holder name field for car payment method" is set to "No", and we leave it like that.

You should set this field to "Yes". Let me know if you are still experiencing this issue with the applied configuration

pmarjan-onestic commented 8 months ago

@RokPopov

no, the issue is gone after applying "Yes" to the configuration.

But, then, this does not answer why the test is failing with the default "No"? Is this, you think, an inaccuracy in the test itself, meaning, there might be a bug in the test? Or, this configuration should be "Yes" by default?

Ultimately, what I would like to achieve as some "automated tester entity" is:

Obviously, without any manual steps in between.

candemiralp commented 8 months ago

bin/magento config:set payment/adyen_abstract/holder_name_required 1can be used on CLI while setting up the pipeline. This issue can be closed.