Closed stutaylor closed 3 years ago
Hello @stutaylor thanks for reporting this. Could you provide more information to try to reproduce? I see that "Order not found." is logged here as part of the payment status check.
With Street line 1 for the house number I'm not able to reproduce in 2.4, maybe the full error has more info?
Hi @acampos1916
So the version of magento i am using is 2.4.2 -p1 on magento cloud
Here is the error in full from the system.log
[2021-06-24 16:48:02] report.CRITICAL: TypeError: Argument 1 passed to Adyen\Payment\Helper\Address::getStreetAndHouseNumberFromAddress() must be an instance of Magento\Payment\Gateway\Data\AddressAdapterInterface, instance of Magento\Sales\Model\Order\Address\Interceptor given, called in /app/vendor/adyen/module-payment/Helper/Requests.php on line 192 and defined in /app/vendor/adyen/module-payment/Helper/Address.php:41 Stack trace:
[2021-06-24 16:48:03] AdyenLoggerTest.ERROR: Order not found. {"is_exception":false} []
Thanks @stutaylor. I think we're only missing the plugin version to try to reproduce, which version are you using?
@acampos1916 Here you go, its
Extension version | 7.1.0
Hi All,
I also have a merchant seeing the same issue, they have tried this on 3 websites including a Sandbox Vanilla Magento 2 and are seeing the below error message.
They say "This HAS to be a module issue to be witnessing the problem across all three sites. And appears to reference an issue with the new logic around an address number lookup.
Any help would be appreciated as they are keen to go live.
Adyen Error Log [2021-06-24 16:40:00] AdyenLoggerTest.ERROR: Order not found. {"is_exception":false} []
Magento System Log [2021-06-24 16:47:00] report.CRITICAL: TypeError: Argument 1 passed to Adyen\Payment\Helper\Address::getStreetAndHouseNumberFromAddress() must be an instance of Magento\Payment\Gateway\Data\AddressAdapterInterface, instance of Magento\Sales\Model\Order\Address\Interceptor given, called in /app/huhjngc2cgkry_stg/vendor/adyen/module-payment/Helper/Requests.php on line 192 and defined in /app/huhjngc2cgkry_stg/vendor/adyen/module-payment/Helper/Address.php:41 Stack trace:
Hello @RobertJohnsonadyen thanks for the report. Which version of the plugin is it in your case? And which version of Magento?
Hi Angel, the plug in they are using 6.7.1 and I have reached out to them to confirm on their Magento 2 but I don't think its the latest, 7.0. I think it is 6 something but will let you know when they come back and confirm!
When upgrading Magento to 2.4.2-p1, the module paypal/module-braintree(-core) is updated from 4.2.1 to 4.2.2. This changes the return-type for the method PayPal\Braintree\Gateway\Data\OrderOrderAdapter::getBillingAddress()
which triggers the typeError. If you are not depending on core-magento Paypal functionality you can just disable the modules in app/etc/config.php
'PayPal_Braintree' => 0,
'PayPal_BraintreeGraphQl' => 0
Thanks for reviewing all! So just to confirm if the merchant/ their SI can disable that module it should fix the error? I will reach out them with this and see if this something they can do if so?
Hi @Basvanderlouw
Thank you for the extra piece of info, I've investigated a couple of other extensions and found that indeed it's pretty common to override the return type for this interface, therefore in the #1086 I removed the interface type declaration (kept it in the phpdoc as a hint though)
Hi @stutaylor, @RobertJohnsonadyen could you please check if this quickfix is solving the issue in your case as well?
Thank you in advance, Attila Adyen
Hi All, Thanks for all your help, this has indeed fixed the issue for my merchant and they are getting test transactions into the system as we speak!
Closing this issue with #1086, if anyone has extra information or comment please let us know. Thank you all.
When checking out and entering card details users are being returned to the cart.
Error in system.log file (part of error) Stack trace:
0 /app/vendor/adyen/module-payment/Helper/Requests.php(192): Adyen\Payment\Helper\Address->getStreetAndHouseNumberFromAddress(Object(Magento\Sales\Model\Order\Address\Interceptor), '1', '3')
Resulting in AdyenLoggerTest.ERROR: Order not found. {"is_exception":false} []
The admin settings are set to map street 1 for the house number
This is happening on multiple installs of Adyen on magento 2.4.+