Adyen / adyen-magento2

Adyen Payment plugin for Magento2
MIT License
155 stars 211 forks source link

[PW-7088][PW-7036] Order status of newly created order struck at payment review, the admin configuration for adyen is pending, checked in 8.3.0,8.3.2,8.3.3 all versions #1660

Closed binuconcept closed 2 years ago

binuconcept commented 2 years ago

Making your own contribution is easy, encouraged and greatly appreciated! We will put effort into reviewing and merging your PR quickly. For more info, please refer to the contribution guidelines: https://github.com/Adyen/adyen-magento2/blob/develop/CONTRIBUTING.md

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Magento version [e.g. 2.4.1]

Plugin version [e.g. 6.6.8]

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

devetus commented 2 years ago

@Morerice @RokPopov could be linked with the critical cron capture issue we've found after upgrading to v8.3.3

[2022-08-11 10:59:11] report.CRITICAL: Error when running a cron job {"exception":"[object] (RuntimeException(code: 0): Error when running a cron job at /vendor/magento/module-cron/Observer/ProcessCronQueueObserver.php:368, Error(code: 0): Call to undefined method Adyen\\Payment\\Helper\\Data::isPaymentMethodOpenInvoiceMethodValidForAutoCapture() at /vendor/adyen/module-payment/Helper/PaymentMethods.php:660)"} []

there is no isPaymentMethodOpenInvoiceMethodValidForAutoCapture method in the helper which is failing all capture updates and invoices in Magento for pending orders.

devetus commented 2 years ago

looks like the method was renamed to isPaymentMethodOpenInvoiceMethod but not updated in all places.

AlexandrosMor commented 2 years ago

It is fixed with the 8.3.5 release

binuconcept commented 2 years ago

Adyen Payment 8.3.5 : cross-checked, the Magento admin configuration of Adyen payment we are setting for order creation is pending but still it's going to payment review. Cross-checked all versions 8.3.0,8.3.2,8.3.3, and 8.3.5 as well still the issue is there.

michaelpaul commented 2 years ago

Hello @binuconcept, thanks for reporting this issue and testing again on the latest release. I've created another internal follow up ticket for it. Feel free to edit this issue's description field with your findings (e.g steps to reproduce, versions, log snippets), that helps a lot on fixing the problem.

Morerice commented 2 years ago

Hi,

Issue was caused by a third party module, tasked with providing fraud prevention. For future reference we recommend using Adyen's Risk Management functionality for fraud prevention.

Thanks, Jean Adyen

GamesmenJordan commented 2 years ago

Issue was caused by a third party module, tasked with providing fraud prevention.

Can you specify which module? Wondering if it is the same module we use (Signifyd)

Morerice commented 2 years ago

Issue was caused by a third party module, tasked with providing fraud prevention.

Can you specify which module? Wondering if it is the same module we use (Signifyd)

Hi @GamesmenJordan,

The module was Forter.

Regards, Jean Adyen

binuconcept commented 2 years ago

Hi @GamesmenJordan It's an issue with Adyen(the module checked all the latest modules this issue is their), Adyen team's future requests will fix this issue. (this is the response received from Adyen technical members)

We may need to add some patches from our end to move forward.

It's not because of Forter. If you are not using forter also you can replicate this issue.