search

Adyen / adyen-magento2

Adyen Payment plugin for Magento2
MIT License
155 stars 211 forks source link

Minification issue with df.js #170

Closed lancergr closed 7 years ago

lancergr commented 7 years ago

When setting JS minification to Yes, the https://live.adyen.com/hpp/js/df.js is resolved as https://live.adyen.com/hpp/js/df.min.js which leads to 404.

Relevant line: https://github.com/Adyen/adyen-magento2/blob/develop/view/frontend/requirejs-config.js#L10

hostep commented 7 years ago

The suggested solution from Magento is to add this url to the minify_exclude node in the config.xml file, see the comment over here: https://github.com/magento/magento2/issues/5835#issuecomment-259474472 & https://github.com/magento/magento2/issues/5835#issuecomment-296290118

I haven't actually tested this, just came across this a while ago and kept it in mind.

(although hosting the file locally is probably better for performance reasons then to fetch it from a remote site, so the solution in the PR is probably the better solution)

lancergr commented 7 years ago

Hi @hostep

Thank you very much for the suggestion! It is indeed better for performance reason to have this file merged in one final .js file so we will ship it with the plugin for now.

Kind Regards, Giorgos Adyen