search

Adyen / adyen-magento2

Adyen Payment plugin for Magento2
MIT License
150 stars 196 forks source link

[ECP-9097] Remove usage of handleReject() for payment methods except for PayPal #2652

Closed SushmitaThakur closed 1 week ago

SushmitaThakur commented 3 weeks ago

Description handlereject() method is not present for component in case of payment methods other than PayPal, this PR includes a base function handleOnfailure() for handling orderRedirect fail for in general payment methods and overrides this method for PayPal ensuring handleReject() is called only if the payment method is PayPal.

Tested scenarios

  1. With Ideal payment, handleOnfailure() should be utilized from base (ayden-pm-method)
  2. With PayPal, handleOnfailure() should be utilized from PayPal method renderer
sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud