[ECP-9290] Undocumented breaking change in 9.6.0

Adyen / adyen-magento2

Adyen Payment plugin for Magento2

MIT License

150 stars 196 forks source link

[ECP-9290] Undocumented breaking change in 9.6.0 #2663

Open Nuranto opened 1 week ago

Nuranto commented 1 week ago

Describe the bug

In 9.6.0, This commit changes the graphql schema : https://github.com/Adyen/adyen-magento2/commit/a2839a368785cb739dcdc98bf859c325757d4f68

Our react checkout was using that details field.

I checked releases notes, I can't find anything about ECP-9053. Can you give us more information about this change ?

RokPopov commented 1 week ago

Hi @Nuranto,

Thank you for spotting and reporting this issue! I have created an internal ticket to remove the breaking change. Once completed, this ticket will automatically close.

Kind regards, Rok

dimitriBouteille commented 1 week ago

Hi @RokPopov

I think the best practice is :

Deprecate the property in schema.graphqls with @deprecated tag
Permanently delete the property in another (major) version

And maybe add breaking change section in release note :)