Adyen / adyen-magento2

Adyen Payment plugin for Magento2
MIT License
155 stars 212 forks source link

Order in pending status if already cancelled #2708

Closed dimitriBouteille closed 1 month ago

dimitriBouteille commented 2 months ago

Describe the bug

Bug is partially fixed in the following MR https://github.com/Adyen/adyen-magento2/pull/2592 but there is still a small problem.

Indeed, if the graphQl adyenPaymentDetails query is executed multiple times for, the order is passed to status pending instead of remaining canceled.

As the following screenshot shows, the order is in pending status after executing adyenPaymentDetails 2 times (or more)

Capture d’écran du 2024-08-13 12-26-25

Capture d’écran du 2024-08-13 14-18-52

To Reproduce

Steps to reproduce the behavior:

  1. Try place order with adyen_twint payment
  2. Cancel payment in Twint interface
  3. Execute adyenPaymentDetails multiple times
  4. The first time the order is cancelled with canceled status and after the order is in pending status ...

Expected behavior

If the order is already cancelled, the status must not change.

Versions

candemiralp commented 2 months ago

Hello @dimitriBouteille,

Thank you for your contribution and raising this issue. I've left a small comment on the PR. Let's discuss the details on the comment.

Best Regards, Can