[ECP-9534] Adyen\Payment\Controller\Return\Index::isResponseAlreadyProcessed() throw exception if comment is empty

Adyen / adyen-magento2

Adyen Payment plugin for Magento2

MIT License

155 stars 211 forks source link

[ECP-9534] Adyen\Payment\Controller\Return\Index::isResponseAlreadyProcessed() throw exception if comment is empty #2775

Closed dimitriBouteille closed 3 weeks ago

dimitriBouteille commented 1 month ago

In some case the order comment can be empty (null) so the function str_contains throw exception :(

Capture d’écran du 2024-10-22 10-34-44

Deprecated Functionality: str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in /vendor/adyen/module-payment/Controller/Return/Index.php on line 213

candemiralp commented 4 weeks ago

Hello @dimitriBouteille,

Thank you for creating this issue. We have created an internal ticket to solve this issue.

Best Regards, Can

khushboo-singhvi commented 3 weeks ago

Hey @dimitriBouteille,

Here is the related PR - https://github.com/Adyen/adyen-magento2/pull/2796 Closing the issue.

Regards! Khushboo