Fix Controller\Index::isResponseAlreadyProcessed() check with empty comment

Adyen / adyen-magento2

Adyen Payment plugin for Magento2

MIT License

155 stars 211 forks source link

Fix Controller\Index::isResponseAlreadyProcessed() check with empty comment #2776

Closed dimitriBouteille closed 2 weeks ago

dimitriBouteille commented 1 month ago

Description

The PR fix the following error :

Deprecated Functionality: str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in /vendor/adyen/module-payment/Controller/Return/Index.php on line 213

In some case, the order comment can be null :

Capture d’écran du 2024-10-22 10-34-44

Fixes #2775

candemiralp commented 4 weeks ago

Hello @dimitriBouteille,

Thank you for creating this PR. However, we have a different proposal for the solution as isResponseAlreadyProcessed() method causes more issues. We will keep this PR here as a temporary solution but will introduce an abstract fix soon.

Best Ragards, Can

dimitriBouteille commented 4 weeks ago

Hi @candemiralp

You know when the fix will be available?

candemiralp commented 2 weeks ago

Hello @dimitriBouteille,

Thank you for your contrition. The fix to the given issue has been introduced in #2796 and will be release in the upcoming release this week. I am closing this issue as it's redundant after the introduced fix.

Best Regards, Can