search

Adyen / adyen-magento2

Adyen Payment plugin for Magento2
MIT License
155 stars 211 forks source link

Undefined index: cc_type AdyenCcDataAssignObserver.php on line 65 #286

Closed ad1s closed 6 years ago

ad1s commented 6 years ago

Magento version: 2.2.4 Plugin version: 2.3.0 Description In checkout, we sometimes get the notice: Notice: Undefined index: cc_type in /vendor/adyen/module-payment/Observer/AdyenCcDataAssignObserver.php on line 65

rikterbeek commented 6 years ago

Hi @ad1s,

cc_type should always be set for the creditcard payment method. Are you able to debug if this notice happen what the value here is ? https://github.com/Adyen/adyen-magento2/blob/develop/view/frontend/web/js/view/payment/method-renderer/adyen-cc-method.js#L141

Regards, Rik Adyen

sanderkwantes commented 6 years ago

Hi @rikterbeek,

We experience the same issue with some orders where 'paymethod' is 'banktransfer'. I cannot see any consistency. We are currently using the M2 API to create orders. Today we got this error response in our logging for about 15 times. Order creation results in failure.

Regards, Sander on behalf of Meitrade B.V.

rikterbeek commented 6 years ago

HI @sanderkwantes,

This is a notice so this can't be a reason for order creation failure. AdyenCcDataAssignObserver will only be called for card payment not alternative payment methods as banktransfer. There should be more logs why order creation results in a failure.

Regards, Rik Adyen

sanderkwantes commented 6 years ago

Hi @rikterbeek ,

You were right, issue is fixed and was not related to your extension.

Thanks, Sander

rikterbeek commented 6 years ago

Hi @sanderkwantes,

Good to hear thanks for the feedback. Closing the issue.

Regards, Rik Adyen

f123248 commented 5 months ago

Hi @rikterbeek ,

You were right, issue is fixed and was not related to your extension.

Thanks, Sander

Hi @sanderkwantes ,

Can you kindly share how you fix it? I faced the same issue that banktransfer was settled the cc_type by a wrong action